Updated the width prop to include more valid CSS values.#210
Open
JapMul wants to merge 1 commit intojossmac:masterfrom
JapMul:width-property
Open
Updated the width prop to include more valid CSS values.#210JapMul wants to merge 1 commit intojossmac:masterfrom JapMul:width-property
JapMul wants to merge 1 commit intojossmac:masterfrom
JapMul:width-property
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Enhances the
widthprop of the lightbox component. After this commit, the property accepts the width value as a plain number, numbers with apx,vwor%suffix,none,inheritandinitial.Related issues (if any):
Fixes #165
Checks:
yarn run lintran successfully/srcand/examples/srcare committed