Skip to content

Fix temperature conversion formula bugs #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jj-devhub wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix temperature conversion formula bugs #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions buggy_temperature.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
def celsius_to_fahrenheit(celsius):
# Bug fixed: correct formula C * 9/5 + 32
fahrenheit = celsius * 9/5 + 32
return fahrenheit

def fahrenheit_to_celsius(fahrenheit):
# Bug fixed: correct order of operations (F - 32) * 5/9
celsius = (fahrenheit - 32) * 5/9
return celsius

print(f"100°C = {celsius_to_fahrenheit(100)}°F")
print(f"212°F = {fahrenheit_to_celsius(212)}°C")
Comment on lines +11 to +12
Copy link

@coderabbitai coderabbitai bot Aug 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Avoid import-time side effects; gate demo prints with main.

Top-level prints execute on import, which can break consumers/tests.

-print(f"100°C = {celsius_to_fahrenheit(100)}°F")
-print(f"212°F = {fahrenheit_to_celsius(212)}°C")
+if __name__ == "__main__":
+    print(f"100°C = {celsius_to_fahrenheit(100)}°F")
+    print(f"212°F = {fahrenheit_to_celsius(212)}°C")
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
print(f"100°C = {celsius_to_fahrenheit(100)}°F")
print(f"212°F = {fahrenheit_to_celsius(212)}°C")
if __name__ == "__main__":
print(f"100°C = {celsius_to_fahrenheit(100)}°F")
print(f"212°F = {fahrenheit_to_celsius(212)}°C")
🤖 Prompt for AI Agents 
In buggy_temperature.py around lines 11 to 12 the module contains top-level demo
print statements that run on import; move those prints into a guarded block so
they only run when the module is executed directly: wrap the two print calls in
an if __name__ == "__main__": block (indent them accordingly) so importing the
module by tests or other code won’t produce side-effect output.