Skip to content

Conversation

@attiasas
Copy link
Contributor

@attiasas attiasas commented Dec 15, 2025

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the master branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

Depends on:

Note: There is still an issue parsing flags/arguments.
This PR only fixing that the inner docker scan cmd flags will be parsed as flags and not arguments.
For the scan to work you need to run: docker scan <img> [flags] (argements before flags)

@github-actions
Copy link
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.


return true
}

func getDockerFlags() []cli.Flag {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no test ?

// Avoiding flag duplication
for _, f := range converted {
if !flagNames.Exists(f.GetName()) {
flagList = append(flagList, f)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use flagNames in the whole method and then convert it to slice ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants