Update GithubSecurityRealm.java for consistency in URL building.#118
Open
johnclyde wants to merge 3 commits intojenkinsci:masterfrom
Open
Update GithubSecurityRealm.java for consistency in URL building.#118johnclyde wants to merge 3 commits intojenkinsci:masterfrom
johnclyde wants to merge 3 commits intojenkinsci:masterfrom
Conversation
There is an open PR to facilitate configuration of redirect_uri but it appears to me that it only hit one of the 2 places that the uri needed to be appended. I am modifying the code for hygiene to make it more obvious where to slip that in (and perhaps also slip in allow_signup).
ramo-digisight
approved these changes
Apr 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an open PR to facilitate configuration of redirect_uri but it appears to me that it only hit one of the 2 places that the uri needed to be appended. I am modifying the code for hygiene to make it more obvious where to slip that in (and perhaps also slip in allow_signup).