Skip to content

Fix RedisCache.close() to check for client before closing. #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wloggains-mmllc wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix RedisCache.close() to check for client before closing. #796

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e7c298f
Fix RedisCache.close() method to check for client existence before cl…
wloggains-mmllc Oct 17, 2025
48bab93
Replace kwargs to client close method
wloggains-mmllc Oct 20, 2025
a7f413f
Add test for RedisCache.close() with uninitialized client
wloggains-mmllc Oct 20, 2025
fe6c741
Merge remote-tracking branch 'origin/add-check-rediscache-close' into…
wloggains-mmllc Oct 20, 2025
570c0f1
Small refactor
wloggains-mmllc Oct 20, 2025
c3bacaf
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion django_redis/cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,8 @@ def lock(self, *args, **kwargs):

@omit_exception
def close(self, **kwargs):
self.client.close(**kwargs)
if self._client:
self.client.close(**kwargs)

@omit_exception
def touch(self, *args, **kwargs):
Expand Down
6 changes: 6 additions & 0 deletions tests/test_backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,6 +532,11 @@ def test_close(self, cache: RedisCache, settings: SettingsWrapper):
cache.set("f", "1")
cache.close()

def test_close_uninitialized_client(self):
cache = RedisCache("default", {})
cache._client = None
cache.close()

def test_close_client(self, cache: RedisCache, mocker: MockerFixture):
mock = mocker.patch.object(cache.client, "close")
cache.close()
Expand Down Expand Up @@ -1029,3 +1034,4 @@ def test_sunionstore(self, cache: RedisCache):
cache.sadd("foo2", "bar2", "bar3")
assert cache.sunionstore("foo3", "foo1", "foo2") == 3
assert cache.smembers("foo3") == {"bar1", "bar2", "bar3"}