Fix sign of tbn generator that caused normal map flipping in some situations #2140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Tested with the ogre format, it displayed the same behavior as gltf. @codex128 when you can, please look into this and let me know your opinion on this patch |
codex128
reviewed
Nov 8, 2023
Contributor
There was a problem hiding this comment.
In general, these changes look good to me, although I don't know enough about normal maps to be absolutely sure.
In order to avoid further problems arising, I think the normal type parameter should be explained on the wiki. This issue is just subtle enough for new users to trip over without realizing it. 😉
jme3-examples/src/main/java/jme3test/material/TestNormalMappingConsistency.java
Show resolved
Hide resolved
jme3-examples/src/main/java/jme3test/material/TestNormalMappingConsistency.java
Show resolved
Hide resolved
jme3-core/src/main/java/com/jme3/util/mikktspace/MikktspaceTangentGenerator.java
Show resolved
Hide resolved
stephengold
added
the
defect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2120 (comment)