Improve error message related to missing telemetry (NSDS-5235) - #332
Open
bhawkins wants to merge 2 commits into
Open
Improve error message related to missing telemetry (NSDS-5235)#332bhawkins wants to merge 2 commits into
bhawkins wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDS has reported several errors related to missing telemetry. The interpretation of the log message isn't so obvious, especially since the logic in an error handling block itself contains an error, so one gets two exception tracebacks. This PR fixes the problem in the low-level error handling and adds a more informative error message in the higher-level code.
The actual problem at hand is that data were collected in a dual-pol mode (HH and HV), but presumably something went awry with the downlink such that only HV made it into the L0B file. The processor is configured with elevation antenna pattern (EAP) correction enabled, and the loopback calibration telemetry is required to compute the patterns. However, there's no such thing as crosspol loopback cal; the transmit-H pattern must be formed using analysis of the HH loopback cal. Since that isn't available in the file, the EAP processing cannot proceed.