Skip to content

[NX-OS] Add BorderGateway resource and controller #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
felix-kaestner merged 2 commits into from
Jan 9, 2026
Merged

[NX-OS] Add BorderGateway resource and controller #138

felix-kaestner merged 2 commits into from
Jan 9, 2026

Conversation

@felix-kaestner
Copy link
Contributor

@felix-kaestner felix-kaestner commented Dec 8, 2025

This change introduces a new custom resource called BorderGateway which is specific to the Cisco NX-OS Platform and allows to configure required features for the border gateway functionality required to deploy Cisco VXLAN EVPN Multi-Site.

@hardikdr hardikdr added the area/metal-automation Automation processes within the Metal project. label Dec 9, 2025
@hardikdr hardikdr added this to Roadmap Dec 9, 2025
@felix-kaestner felix-kaestner force-pushed the fix/port-speeds branch 2 times, most recently from dd1ddc9 to da70376 Compare December 11, 2025 15:22
@felix-kaestner felix-kaestner marked this pull request as ready for review December 11, 2025 15:54
@felix-kaestner felix-kaestner requested a review from a team as a code owner December 11, 2025 15:54
@felix-kaestner felix-kaestner force-pushed the nx/bgw branch 2 times, most recently from e484e01 to c4225a1 Compare December 15, 2025 12:03
Base automatically changed from fix/port-speeds to main December 19, 2025 15:02
@felix-kaestner felix-kaestner force-pushed the nx/bgw branch 2 times, most recently from e465cf5 to 87f4fab Compare January 8, 2026 09:14
nikatza
nikatza approved these changes Jan 8, 2026
View reviewed changes
Copy link
Contributor

@nikatza nikatza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice.

@felix-kaestner felix-kaestner force-pushed the nx/bgw branch 5 times, most recently from 48f20be to 2a25ff1 Compare January 9, 2026 10:25
@felix-kaestner
Refactor Device Controller Tests
3fcc096
@felix-kaestner
[NX-OS] Add BorderGateway resource and controller
1b76846 
This change introduces a new custom resource called `BorderGateway`
which is specific to the Cisco NX-OS Platform and allows to configure
required features for the border gateway functionality required to
deploy Cisco VXLAN EVPN Multi-Site.
@github-actions
Copy link

github-actions bot commented Jan 9, 2026

Merging this branch changes the coverage (2 decrease, 1 increase)

Impacted Packages Coverage Δ 🤖
github.com/ironcore-dev/network-operator/api/cisco/nx/v1alpha1 0.00% (ø)
github.com/ironcore-dev/network-operator/api/core/v1alpha1 0.00% (ø)
github.com/ironcore-dev/network-operator/cmd 0.00% (ø)
github.com/ironcore-dev/network-operator/internal/controller/cisco/nx 65.78% (-8.33%) 👎
github.com/ironcore-dev/network-operator/internal/controller/core 69.57% (+0.04%) 👍
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos 11.63% (-0.37%) 👎
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/ironcore-dev/network-operator/api/cisco/nx/v1alpha1/bordergateway_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/cisco/nx/v1alpha1/zz_generated.deepcopy.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/groupversion_info.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/cmd/main.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/internal/controller/cisco/nx/bordergateway_controller.go 52.91% (+52.91%) 206 (+206) 109 (+109) 97 (+97) 🌟
github.com/ironcore-dev/network-operator/internal/controller/cisco/nx/provider.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/bgp.go 21.15% (-1.35%) 52 (+12) 11 (+2) 41 (+10) 👎
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/bgw.go 75.00% (+75.00%) 4 (+4) 3 (+3) 1 (+1) 🌟
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/intf.go 19.20% (-0.13%) 125 (+6) 24 (+1) 101 (+5) 👎
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/provider.go 0.08% (-0.01%) 1326 (+88) 1 1325 (+88) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/ironcore-dev/network-operator/internal/controller/cisco/nx/bordergateway_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/cisco/nx/suite_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/device_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/bgp_test.go
  • github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/bgw_test.go
  • github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/intf_test.go

@felix-kaestner felix-kaestner merged commit 4bc60a2 into main Jan 9, 2026
8 checks passed
@felix-kaestner felix-kaestner deleted the nx/bgw branch January 9, 2026 11:16
@github-project-automation github-project-automation bot moved this to Done in Roadmap Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikatza nikatza nikatza approved these changes

Assignees

No one assigned

Labels

area/metal-automation Automation processes within the Metal project.

Projects

Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@felix-kaestner @nikatza @hardikdr