Add .js extension to require #49
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
No, this works around a bug in vite. The extension MUST NOT be required in commonjs requires, or else the tool is broken. Separately, the I suggest filing an issue on vite. |
Author
|
@ljharb I don't think it's a vite bug. Also, optional chaining says node 14+ and node 14 has been EOL for years. Why support versions before that? |
Member
|
If it works in node, and it doesn't work in a bundler, it is always a bug in the bundler. We support down to node 0.4, primarily because old node versions are very useful stand-ins for the old browser versions millions of people still run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with vite where it is strict about the file extension existing.