ci: ungated check-only Lint workflow (ruff + black) + blame-ignore + docs#681
Conversation
|
Overall Assessment ✅ Looks good. No unmitigated P0/P1 findings. Executive Summary
Methodology No findings. Affected methods: none. The diff is limited to CI, blame-ignore metadata, changelog, and contributor docs; Code Quality No findings. Performance No findings. The new workflow runs cheap static checks only. Maintainability No findings. The stable Tech Debt No findings. No new deferred methodology or correctness debt is introduced. Security No findings. Documentation/Tests
|
|
🔁 AI review rerun (requested by @igerber) Head SHA: Overall Assessment ✅ Looks good. No unmitigated P0/P1 findings. Executive Summary
Methodology No findings. The diff does not touch Code Quality No findings. Performance No findings. The new CI job runs cheap static checks only. Maintainability No blocking findings. Tech Debt No findings. No new deferred methodology or correctness debt is introduced. Security No findings. Documentation/Tests
Validation note: I attempted the focused pin-sync test, but |
|
🔁 AI review rerun (requested by @igerber) Head SHA: Overall Assessment ✅ Looks good. No unmitigated P0/P1 findings. Executive Summary
Methodology No findings. The PR does not touch Code Quality No findings. The Performance No findings. The new workflow runs cheap static checks only: Maintainability No findings. The pin-sync contract is now executable via Tech Debt No findings. No new deferred correctness, methodology, or inference debt is introduced. Security No findings. The workflow has top-level Documentation/Tests No findings. The changelog and contributor docs accurately describe the current lint workflow and blame-ignore setup. Validation note: I attempted to run the focused pytest guards, but this review environment does not have |
igerber
added
ready-for-ci
…docs - .github/workflows/lint.yml: runs `ruff check` + `black --check` at the pyproject-pinned versions on every PR push and on pushes to main. No ready-for-ci gate (precedent: ai_pr_review.yml), no paths filter (a required check whose workflow never triggers would block PRs forever). Aggregate "Lint Gate" job (if: always(), inspects needs.*.result) gives branch protection a single stable required-check name. Check-only. - .git-blame-ignore-revs: the #677/#679 normalization squash SHAs. - CONTRIBUTING.md "Linting and Formatting" section + CLAUDE.md note. - TestLintWorkflowPinSync: executable ruff/black pin-sync guard between lint.yml and the pyproject dev extra (review round-2 P3). - lint.yml added to rust-test.yml push/pull_request path filters, locked by PIN_SYNC_WORKFLOWS assertions; docs distinguish the current ruff/black mirroring from the future mypy CI job (round-3 P3s). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Lbd6nqWmg4snvvBmegwqiw
igerber
force-pushed
the
ci/lint-workflow
branch
from
b362ce5 to
06ae0f6
Compare
|
🔁 AI review rerun (requested by @igerber) Head SHA: Overall Assessment ✅ Looks good. No unmitigated P0/P1 findings. Executive Summary
Methodology No findings. Affected methods: none. This PR changes CI, blame-ignore metadata, docs, changelog, and review-workflow tests only; no estimator or methodology registry cross-check is required. Code Quality No findings. The workflow structure is straightforward and keeps a stable required-check job name while preserving failure propagation. Performance No findings. The added workflow runs only Maintainability No findings. The new path-filter tests and pin-sync guard cover the main drift risks introduced by this CI workflow. Tech Debt No findings. No new deferred correctness or methodology debt is introduced. Security No findings. The workflow has Documentation/Tests No findings. Contributor docs and Validation note: I attempted the focused pytest run, but this environment lacks |
1 participant
Summary
.github/workflows/lint.yml: check-only (never modifies code)ruff check diff_diff tests+black --check diff_diff testsat the versions pinned in thedevextra (chore: pin lint tooling + normalize source and hand-fixed test files (1/2) #677). Runs ungated on every PR push (precedent: ai_pr_review.yml) plus pushes to main to catch merge-skew; deliberately nopaths:filter (a required check whose workflow never triggers blocks PRs forever on "Expected"). Actions SHA-pinned per repo convention; top-levelpermissions: contents: read; concurrency-cancel per PR.Lint Gatejob (needs: [format-lint],if: always(), fails unless every upstream result is success) gives branch protection a single stable required-check name.if: always()is load-bearing: a skipped required check counts as satisfied on GitHub, so the gate must run and inspect results explicitly. The planned mypy job (next PR in this program) will extendneedswith no protection change..git-blame-ignore-revslisting the chore: pin lint tooling + normalize source and hand-fixed test files (1/2) #677/chore: mechanical black/ruff normalization of remaining test files (2/2) #679 normalization squash SHAs (the chore: pin lint tooling + normalize source and hand-fixed test files (1/2) #677 squash also carries that PR's small hand fixes - noted in the file comment as an accepted squash-convention trade-off).Post-merge handoff (manual, one-time)
After this merges and the Lint workflow has run green on main: add Lint Gate to the required status checks for
mainin branch protection. No further protection change will be needed when the mypy job is added.Methodology references (required if estimator / math changes)
diff_diff/changesValidation
tests/test_openai_review.py -m ''run green (250 passed - the workflow-guard suite; all its classes are scoped to named workflow files, so the new lint.yml violates nothing). YAML parse verified; blame-ignore attribution smoke-tested (git -c blame.ignoreRevsFile=... blameon a reformatted file attributes to the pre-normalization commit);ruff check+black --checkclean on this tree, so the workflow dogfoods green on this very PR.Security / privacy
Generated with Claude Code
🤖 Generated with Claude Code
https://claude.ai/code/session_01Lbd6nqWmg4snvvBmegwqiw