feat: Formation Flight - possibility to show peer name#11744
Draft
error414 wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FormationFlight transmits first three letters from aicraft name, but original MSP command MSP2_COMMON_SET_RADAR_POS does not supports it. So I added new MSP command to to be possible send peer name.
I decided to create new MSP command because I did not want to break compatibility. Command MSP2_COMMON_SET_RADAR_POS is used for ESP32-INAV-Radar and Ardupilot. So it's not possible to change structure of command.
Second posibility is send diferent command from FormationFlight if inav is detected, I don't like it.
Command MSP2_COMMON_SET_RADAR_PEER_NAME contains max_name_lenght so for future it's possible increase name lenght without breaking compatibility.
I will prepare PR for FormationFlight as well, it's not big change, and it does not break compatibility for Ardupilot.
The configurator needs to be adjusted as well, I will do that when aproach in this PR will be aproved
BTW: there is problem with peer indexes, original ESP32-INAV-Radar uses indexes 0 - X, FormationFlight starts with index 1, index 1 is used for "self", so first index whis is sent to inav is 2, it's a reasson why you see peers C, D, E ...
I made mistake when I created fixed OSD element, I dropped decreased index -1 so first letter what you can see is B (FormationFlight), and first peer is not displayed (ESP32-INAV-Radar). The question is if drop support for ESP32-INAV-Radar is good idea, I would not like do that.