Skip to content

fix: ignore datasetorder burned TEE frameworks tags from deal tag computation#533

Merged
PierreJeanjacquot merged 3 commits intomasterfrom
fix/ignore-burned-tags
Feb 5, 2026
Merged

fix: ignore datasetorder burned TEE frameworks tags from deal tag computation#533
PierreJeanjacquot merged 3 commits intomasterfrom
fix/ignore-burned-tags

Conversation

@PierreJeanjacquot
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Feb 3, 2026

🐳 Hadolint Dockerfile Lint Results

Click to expand detailed results
Dockerfile:17 DL3016 warning: Pin versions in npm. Instead of `npm install <package>` use `npm install <package>@<version>`

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements a fix to ignore TEE framework tags from dataset orders when computing deal tags, aligning the SDK with blockchain behavior where dataset TEE framework tags are "burned" (ignored).

Changes:

  • Added stripTeeFrameworkFromTag utility function to clear TEE framework bits (bits 1, 2, 3) from tags
  • Updated tag computation logic to strip TEE framework bits from dataset tags before summing with app and request tags
  • Refactored tag encoding/decoding functions to use native BigInt instead of BN.js for cleaner, more modern code

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/common/utils/utils.js Added stripTeeFrameworkFromTag function and refactored tag utilities to use BigInt
src/common/market/order.js Updated tag validation logic to strip TEE frameworks from dataset tags
src/lib/IExecOrderModule.js Applied dataset tag stripping in order matching preflight checks
src/cli/cmd/iexec-order.js Applied dataset tag stripping in CLI order fill command
src/cli/cmd/iexec-app.js Applied dataset tag stripping when computing minimum required tags
test/lib/unit/utils.test.js Added unit test for stripTeeFrameworkFromTag function
test/lib/e2e/IExecOrderModule.test.js Added e2e test demonstrating burned tag behavior and reformatted existing tests

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@PierreJeanjacquot PierreJeanjacquot merged commit 177e2b4 into master Feb 5, 2026
13 of 14 checks passed
@PierreJeanjacquot PierreJeanjacquot deleted the fix/ignore-burned-tags branch February 5, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants