fix: ignore datasetorder burned TEE frameworks tags from deal tag computation#533
Merged
PierreJeanjacquot merged 3 commits intomasterfrom Feb 5, 2026
Merged
fix: ignore datasetorder burned TEE frameworks tags from deal tag computation#533PierreJeanjacquot merged 3 commits intomasterfrom
PierreJeanjacquot merged 3 commits intomasterfrom
Conversation
🐳 Hadolint Dockerfile Lint ResultsClick to expand detailed resultsDockerfile:17 DL3016 warning: Pin versions in npm. Instead of `npm install <package>` use `npm install <package>@<version>` |
2f1e054 to
c76a63f
Compare
There was a problem hiding this comment.
Pull request overview
This PR implements a fix to ignore TEE framework tags from dataset orders when computing deal tags, aligning the SDK with blockchain behavior where dataset TEE framework tags are "burned" (ignored).
Changes:
- Added
stripTeeFrameworkFromTagutility function to clear TEE framework bits (bits 1, 2, 3) from tags - Updated tag computation logic to strip TEE framework bits from dataset tags before summing with app and request tags
- Refactored tag encoding/decoding functions to use native BigInt instead of BN.js for cleaner, more modern code
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/common/utils/utils.js | Added stripTeeFrameworkFromTag function and refactored tag utilities to use BigInt |
| src/common/market/order.js | Updated tag validation logic to strip TEE frameworks from dataset tags |
| src/lib/IExecOrderModule.js | Applied dataset tag stripping in order matching preflight checks |
| src/cli/cmd/iexec-order.js | Applied dataset tag stripping in CLI order fill command |
| src/cli/cmd/iexec-app.js | Applied dataset tag stripping when computing minimum required tags |
| test/lib/unit/utils.test.js | Added unit test for stripTeeFrameworkFromTag function |
| test/lib/e2e/IExecOrderModule.test.js | Added e2e test demonstrating burned tag behavior and reformatted existing tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2cc9cab to
094db45
Compare
094db45 to
c705c74
Compare
abbesBenayache
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.