Skip to content

update selective disclosure#198

Merged
varsha766 merged 16 commits into
developfrom
sd/configure
Jul 6, 2026
Merged

update selective disclosure#198
varsha766 merged 16 commits into
developfrom
sd/configure

Conversation

@Pratap2018

@Pratap2018 Pratap2018 commented Jun 30, 2026

Copy link
Copy Markdown
Member

Title

Provide a short, descriptive title of the change (50 characters max recommended).

  • Added toggle for requesting fields for selective disclosure

Summary

One-paragraph summary describing what the change does and why. Link related issue(s) or design docs.


Background / Motivation

Explain the context, problem being solved, and any alternatives considered. Include links to design docs, issues, or RFCs.


Scope of Changes

  • Files / modules affected (high level)
  • Public API changes (if any)
  • Database / schema / migration impact (if any)

Type

  • Feature
  • Bugfix
  • Docs
  • Refactor
  • Tests
  • Performance
  • Build / CI / Config

Implementation

Describe the approach taken, key design decisions, and why.


Testing & QA

  • Units / integration tests added: describe coverage and important test cases
  • Manual / exploratory test steps for QA
  • CI matrix: platforms/versions validated

Migration / Rollout Plan

  • Data migrations and downtime expectations
  • Backwards compatibility notes
  • Feature flags and staged rollout instructions

Security / Privacy Considerations

List any security implications, new secrets, or compliance-related items.


Performance Impact

Any benchmark results or expected performance regressions/improvements.


Release Notes (for changelog)

One-line summary suitable for release notes / CHANGELOG.


Checklist (required)

  • Linked issue or ticket present (link: )
  • Target branch is correct
  • PR description explains the why, not just the what
  • Code compiles and tests pass locally
  • Unit and integration tests added where applicable
  • Documentation updated (README, docs site, comments)
  • CHANGELOG.md (or repo-specific changelog) updated with an entry
  • package.json / package version updated if publishing a release
  • No secrets or credentials committed
  • Security review completed if required
  • Performance benchmarks included if applicable
  • Migration steps included if applicable

Reviewer Guidance

List the specific areas you want reviewers to focus on (e.g., security, migration, public API, edge cases). Provide commands or steps to run the project locally to validate the change:

# checkout PR branch
git checkout $BRANCH
# run tests
npm ci && npm test
# run lint
npm run lint

Acceptance Criteria

Define the minimal conditions that must be true for this PR to be merged (e.g., tests pass, performance threshold met, migration completed).


Approvals

  • At least one approving review from code owners
  • CI status checks are green
  • Any required manual QA sign-off

@varsha766 varsha766 requested a review from Vishwas1 July 2, 2026 07:38
@varsha766 varsha766 changed the base branch from zkp/widget-config to develop July 2, 2026 07:40
@varsha766 varsha766 marked this pull request as ready for review July 2, 2026 10:54
ageProofCriteria: '',
defaultSelectiveDisclosureFields: ['docModel', 'givenNames', 'surname', 'sex', 'nationality', 'dateOfBirth'],
selectiveDisclosureFieldOptions: [
{ value: 'docModel', text: 'Document Type' },

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its quite confusing,

here we are using docModel as Document Type field but in backend we have two different fields docModel and docType. I suggest we sohuld align both frontend and backend

@varsha766 varsha766 merged commit 153c734 into develop Jul 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants