FIX MiSS with bat init error with some quantization backends#3381
Open
BenjaminBossan wants to merge 1 commit into
Open
FIX MiSS with bat init error with some quantization backends#3381BenjaminBossan wants to merge 1 commit into
BenjaminBossan wants to merge 1 commit into
Conversation
When using MiSS with the init_weights='bat', the forward pass requires getting the non-quantized base weights. When the quantization backend does not support dequantization, we now detect this and raise a helpful error message. Tests have been updated to check for this error message. Normally, we should have caught this error. The reason why we didn't is that we have a helper function for testing that changes PEFT config kwargs to be non-zero initialization. When passing init_weights='bat' to that function, we would override 'bat' with False. Thus, the 'bat' path was not actually being tested. The helper function has now been updated not to override 'bat'.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using MiSS with the
init_weights='bat', theforwardpass requires getting the non-quantized base weights. When the quantization backend does not support dequantization, we now detect this and raise a helpful error message. Tests have been updated to check for this error message.Normally, we should have caught this error. The reason why we didn't is that we have a helper function for testing that changes PEFT config
kwargsto be non-zero initialization. When passinginit_weights='bat'to that function, we would override'bat'withFalse. Thus, the'bat'path was not actually being tested. The helper function has now been updated not to override'bat'.