Skip to content

DCWL-2621 Logging improvements #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
garrypeace-hmrc wants to merge 3 commits into
base: main
Choose a base branch
from
Open

DCWL-2621 Logging improvements #103

garrypeace-hmrc wants to merge 3 commits into from

Conversation

@garrypeace-hmrc
Copy link

@garrypeace-hmrc garrypeace-hmrc commented Sep 23, 2024

Please ensure we are following our Ways of Working for Pull Requests: https://confluence.tools.tax.service.gov.uk/display/BTL/Ways+of+Working+for+Pull+Requests

@platops-pr-bot
Copy link

platops-pr-bot commented Sep 23, 2024

  • uk.gov.hmrc.sbt-auto-build can be updated to 3.22.0 in project/plugins.sbt
  • STDOUT_IGNORE_NETTY appender (and usage) can be removed from conf/logback.xml - Netty server is no longer used (Since Play 2.6.x)
  • ACCESS_LOG_FILE appender (and usage) can be removed from conf/logback.xml - it's never populated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gavinharris43 gavinharris43 gavinharris43 approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@garrypeace-hmrc @platops-pr-bot @gavinharris43