revert(media-use): remove bundled SFX diagnostics#2465
Closed
miguel-heygen wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reverts the bundled-SFX diagnostics from #2460 to restore green required CI on
main.Why
#2460 introduced an unformatted
skills/media-use/scripts/resolve.mjs. The first completed CI run at that commit (run 29382994067, 2026-07-15 01:59 UTC) failedbun run format:check; later main runs inherited the same deterministic failure, and relevant regression/Windows workflows failed their shared format preflight. The last completed green main CI before this commit was run 29379439986.How
This is the exact reverse of commit
da19f9a69267fe5f706b97e13a21ecf6852b4e5b/ #2460. No later main commit changed the five reverted files, so the rollback is isolated and conflict-free.Test plan
bun run format:check— 3,118 files cleanbun run test:skills— 259 tests passedbun packages/cli/scripts/gen-skills-manifest.ts --check— manifest in sync