fix(engine): ignore benign media request aborts#2423
Open
miguel-heygen wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
net::ERR_ABORTEDdiagnostics for media requests cancelled during probe/seek.ogaRoot cause
The capture session appended every
requestfailedevent to its browser diagnostic buffer. Chromium commonly aborts media requests while the probe discovers or seeks audio/video, and producer probe treated any bufferednet::ERR_*line as an asset-load warning even when the final media rendered correctly.Regression coverage
@hyperframes/enginetargeted test: 20/20@hyperframes/enginetypecheckReview
Independent review caught missing
.ogafallback coverage; fixed and re-reviewed with no remaining findings.Source feedback: https://heygen.slack.com/archives/C0BGC335AQY/p1784020062434169
Reviewer action: verify benign abort suppression does not hide real media/network failures, then approve if CI is green.