perf: calculate permalink field only when needed #5703
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
We don't necessarily need to calculate all potentially available fields of the permalink in advance. I myself never use
hashor any dates in my permalink.We should not have to deal with moment.js or sha1 overhead. We can actually calculate those expensive fields on demand.
I use
foxtsbecause I happen to have this exist in my util library. But I can always copy the implementation tohexo-utilif needed.Screenshots
Pull request tasks