-
Notifications
You must be signed in to change notification settings - Fork 235
feat: adding conditional logic for receiving applied state of trusted ips #3424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd respective messaging
|
Git2Gus App is installed but the |
tlowrimore-heroku
approved these changes
Dec 4, 2025
Contributor
tlowrimore-heroku
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
mandelbro
requested changes
Dec 4, 2025
Contributor
mandelbro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a comment/question
mandelbro
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Surfaces the
appliedstate of Trusted IP rules in the CLI. When rules are not applied, users see a warning with guidance to update their Trusted IP list to trigger re-application. Whenappliedstate is present, the following messages may be added in addition.applied is true:
Trusted IP rules are applied to this space.
applied is false:
Trusted IP rules are not applied to this space. Update your Trusted IP list to trigger a re-application of the rules.
Type of Change
Note: Add a
!after your change type to denote a breaking change.Testing
Follow guide for staging heroku environment here: staging setup.
You may test the output of the commands is unchanged (also validated by the tests).
Expected Output to Compare
Additional Context
applied?: booleanfield toInboundRulesetinterface infir.d.tsspaces:trusted-ips(list) command to display applied status after showing rulesspaces:trusted-ips:addcommand to fetch ruleset after PUT and display applied statusspaces:trusted-ips:removecommand to fetch ruleset after PUT and display applied statusapplied === true: "Trusted IP rules are applied to this space."applied === false: Warning "Trusted IP rules are not applied to this space. Update your Trusted IP list to trigger a re-application of the rules."applied === undefined: No message (backward compatibility)appliedfield is optional to support API versions that don't include it yet. When the API always includes it, we can simplify by changingapplied?: booleantoapplied: booleanand removing undefined checks.Related Issue
Resolves W-19525782 - CLI should surface the
appliedstate of Trusted IP updates