feat: add docker login function #1450
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denis256
reviewed
Oct 23, 2024
Member
denis256
left a comment
denis256
left a comment
There was a problem hiding this comment.
To ensure the long-term reliability of this feature, I recommend adding automated tests that specifically track the login functionality.
modules/docker/login.go
Outdated
| } | ||
|
|
||
| // login runs the 'docker login' command to login the given registry. | ||
| func login(t testing.TestingT, opt LoginOptions) error { |
Member
There was a problem hiding this comment.
No public function which return error, similar to Push() / PushE()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hello folks!
Just added docker login for testing to push images to a private registry.
Only for testing purpose because use --password options.
TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Added docker login
Migration Guide