feat(internal/librarian/java): add extractSnippets for README generation#6597
Open
yangyzs wants to merge 5 commits into
Open
feat(internal/librarian/java): add extractSnippets for README generation#6597yangyzs wants to merge 5 commits into
yangyzs wants to merge 5 commits into
Conversation
…README Add minLeadingSpaces and trimLeadingWhitespace helper functions to calculate and normalize code snippet indentation for README block rendering. Add unit tests in readme_test.go. For googleapis#6515
…r README rendering Add collectSnippetFiles and extractSnippetsFromFile helpers to scan Java and XML sample files for code snippets. Add unit tests in readme_test.go. For googleapis#6515
Add extractSnippets main function to collect sample files, extract code snippets, and trim leading whitespace across a directory. Add unit tests in readme_test.go. For googleapis#6515
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces functionality to recursively scan, extract, and trim tagged code snippets from Java and XML files within a samples directory, along with comprehensive unit tests. The reviewer suggests using strings.Split instead of bufio.NewScanner when parsing files to prevent potential silent data loss if any line exceeds the default token limit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This pull request builds on top of #6593 and #6592. Please review and merge those first.
Add extractSnippets main function to collect sample files, extract code snippets, and trim leading whitespace across a directory. Add unit tests in readme_test.go.
For #6515