feat(internal/librarian/java): add README partials loader#6596
Open
yangyzs wants to merge 2 commits into
Open
Conversation
Add toCamelCase, parseGroupIDArtifactID, and parseRepoShortName helpers to format Maven coordinates, repository names, and identifiers for README generation. Add unit tests in readme_test.go. For googleapis#6515
Add loadReadmePartials helper function to load and camel-case custom README partials from .readme-partials.yaml or .yml. Add unit tests in readme_test.go. For googleapis#6515
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces several helper functions in internal/librarian/java/readme.go to parse Maven distribution coordinates, extract short repository names, convert strings to CamelCase, and load README partials from YAML files, along with comprehensive unit tests in readme_test.go. The review feedback suggests optimizing the toCamelCase function to avoid unnecessary memory allocations from []rune conversions by using utf8.DecodeRuneInString and importing the `
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This pull request builds on top of #6595. Please review and merge #6595 first.
Add loadReadmePartials helper function to load and camel-case custom README partials from .readme-partials.yaml or .yml. Add unit tests in readme_test.go.
For #6515