feat(sidekick): refine resource identification heuristics#5299
feat(sidekick): refine resource identification heuristics#5299haphungw wants to merge 7 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a fallback heuristic for resource identification, enabling the system to identify target resources from method input fields when path templates are missing. It also adds default path bindings for gRPC methods. The review feedback points out that the heuristic logic is currently unreachable for methods with a nil PathInfo and suggests a more idiomatic approach for accessing nested message fields by using the MessageType property directly instead of performing manual lookups.
|
@haphungw it looks like this PR hasn't been updated in a week. Do you still plan to work on it? |
|
Hi @julieqiu, yes, I still plan to work on this. We are deferring it until after the code freeze to avoid risk. I'll resume work then. |
|
Thanks @haphungw! Since the code freeze is lasting for more than another week, would you mind closing this PR and then reopening it when it is ready for review, per https://github.com/googleapis/librarian/blob/main/CONTRIBUTING.md#keeping-the-pull-request-dashboard-clean? |
haphungw
force-pushed
the
demo-o11y-heuristic
branch
5 times, most recently
from
0b48ee9 to
24d3877
Compare
When generating code for methods without http mappings, we create a synthetic path binding so that resource heuristics can be applied. However, the Rust transport template expects every binding to have an http verb. This change sets a default value (POST) for the synthetic binding verb, preventing compilation errors in the generated Rust code.
haphungw
force-pushed
the
demo-o11y-heuristic
branch
from
24d3877 to
d97e003
Compare
|
This is still marked as draft. Do we still need it? |
|
There's a change to the solution for this. I'm still working on it. |
3 participants
Add message-based fallback heuristics to identify resource names.
Staged @ googleapis/google-cloud-rust#5561
Fixes #5384