Skip to content

chore(hermetic_build): remove obsolete hermetic build source code and workflows#13616

Merged
zhumin8 merged 1 commit into
googleapis:mainfrom
zhumin8:rm-hermetic-source
Jul 1, 2026
Merged

chore(hermetic_build): remove obsolete hermetic build source code and workflows#13616
zhumin8 merged 1 commit into
googleapis:mainfrom
zhumin8:rm-hermetic-source

Conversation

@zhumin8

@zhumin8 zhumin8 commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Remove the old hermetic_build tool and workflows since the project has migrated to Librarian for library generation. This change keeps google-cloud-java/sdk-platform-java/hermetic_build/library_generation/owlbot intact, will do a followup to cleanup bits inside owlbot package that is not used anymore.

  • Delete common/ and release_note_generation/ directories under sdk-platform-java/hermetic_build/.
  • Remove all files under sdk-platform-java/hermetic_build/library_generation/ except the owlbot/ package, setup.py, requirements.txt/requirements.in, and __init__.py.
  • Move the POM comparison helper script compare_poms.py into tests/owlbot/ to keep the remaining Owlbot test suite fully self-contained.
  • Delete unused build/test workflows, composite action, and scripts (hermetic-build-scripts-ci.yaml,.cloudbuild/library_generation/, .github/scripts/action.yaml, and .github/scripts/hermetic_library_generation.sh).
  • Update release-please-config.json and AGENTS.md references to reflect the removed files.

For googleapis/librarian#5237

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cleans up the repository by removing a large number of files, scripts, templates, and tests related to the hermetic library generation tool, as well as updating configuration files and documentation to remove references to these deleted assets. Feedback on the changes highlights a PEP 8 style issue in compare_poms.py, where a function definition is incorrectly placed in the middle of the import block and a duplicate import of the sys module is introduced.

Comment on lines +8 to +12
import sys

def eprint(*args, **kwargs):
print(*args, file=sys.stderr, **kwargs)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To adhere to PEP 8, all imports should be placed at the top of the file, before any function definitions. Currently, eprint is defined before xml.etree.ElementTree and Counter are imported, and sys is imported twice (at the top and at the bottom). Please move the definition of eprint to the end of the import block (after the existing imports) and remove the duplicate import sys statement.

References
  1. Imports are always put at the top of the file, just after any module comments and docstrings, and before module globals and constants. (link)

@zhumin8 zhumin8 marked this pull request as ready for review July 1, 2026 12:53
@zhumin8 zhumin8 requested review from a team as code owners July 1, 2026 12:53
@zhumin8 zhumin8 merged commit 5590509 into googleapis:main Jul 1, 2026
406 of 419 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants