chore(hermetic_build): remove obsolete hermetic build source code and workflows#13616
Conversation
There was a problem hiding this comment.
Code Review
This pull request cleans up the repository by removing a large number of files, scripts, templates, and tests related to the hermetic library generation tool, as well as updating configuration files and documentation to remove references to these deleted assets. Feedback on the changes highlights a PEP 8 style issue in compare_poms.py, where a function definition is incorrectly placed in the middle of the import block and a duplicate import of the sys module is introduced.
| import sys | ||
|
|
||
| def eprint(*args, **kwargs): | ||
| print(*args, file=sys.stderr, **kwargs) | ||
|
|
There was a problem hiding this comment.
To adhere to PEP 8, all imports should be placed at the top of the file, before any function definitions. Currently, eprint is defined before xml.etree.ElementTree and Counter are imported, and sys is imported twice (at the top and at the bottom). Please move the definition of eprint to the end of the import block (after the existing imports) and remove the duplicate import sys statement.
References
- Imports are always put at the top of the file, just after any module comments and docstrings, and before module globals and constants. (link)
Remove the old hermetic_build tool and workflows since the project has migrated to Librarian for library generation. This change keeps
google-cloud-java/sdk-platform-java/hermetic_build/library_generation/owlbotintact, will do a followup to cleanup bits insideowlbotpackage that is not used anymore.common/andrelease_note_generation/directories undersdk-platform-java/hermetic_build/.sdk-platform-java/hermetic_build/library_generation/except theowlbot/package,setup.py,requirements.txt/requirements.in, and__init__.py.compare_poms.pyintotests/owlbot/to keep the remaining Owlbot test suite fully self-contained.hermetic-build-scripts-ci.yaml,.cloudbuild/library_generation/,.github/scripts/action.yaml, and.github/scripts/hermetic_library_generation.sh).release-please-config.jsonandAGENTS.mdreferences to reflect the removed files.For googleapis/librarian#5237