chore: update librarian to v0.23.1-0.20260630163952-027103b81777 and update utilities to address new .repo-metadata.json values#13586
chore: update librarian to v0.23.1-0.20260630163952-027103b81777 and update utilities to address new .repo-metadata.json values#13586sofisl wants to merge 7 commits into
Conversation
sofisl
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request simplifies transport handling by removing the conversion mapping in utilities.py and directly using the transport value. It also updates the README Jinja template to support rest and grpc+rest transport types, and updates the golden test metadata accordingly. The review feedback suggests using the in operator with a list of values in the Jinja template instead of multiple or conditions to make the code more concise and maintainable.
| {% elif metadata['repo']['transport'] == 'http' or metadata['repo']['transport'] == 'rest' -%} | ||
| {{metadata['repo']['name_pretty']}} uses HTTP/JSON for the transport layer. | ||
| {% elif metadata['repo']['transport'] == 'both' -%} | ||
| {% elif metadata['repo']['transport'] == 'both' or metadata['repo']['transport'] == 'grpc+rest' -%} | ||
| {{metadata['repo']['name_pretty']}} uses both gRPC and HTTP/JSON for the transport layer. |
There was a problem hiding this comment.
Using the in operator with a list of values is more concise and idiomatic in Jinja templates than multiple or conditions. This also makes it easier to maintain if more transport types are added in the future.
| {% elif metadata['repo']['transport'] == 'http' or metadata['repo']['transport'] == 'rest' -%} | |
| {{metadata['repo']['name_pretty']}} uses HTTP/JSON for the transport layer. | |
| {% elif metadata['repo']['transport'] == 'both' -%} | |
| {% elif metadata['repo']['transport'] == 'both' or metadata['repo']['transport'] == 'grpc+rest' -%} | |
| {{metadata['repo']['name_pretty']}} uses both gRPC and HTTP/JSON for the transport layer. | |
| {% elif metadata['repo']['transport'] in ['http', 'rest'] -%} | |
| {{metadata['repo']['name_pretty']}} uses HTTP/JSON for the transport layer. | |
| {% elif metadata['repo']['transport'] in ['both', 'grpc+rest'] -%} | |
| {{metadata['repo']['name_pretty']}} uses both gRPC and HTTP/JSON for the transport layer. |
…etadata (#6582) Remove the Java-specific mapping in RepoMetadataTransport that translated transport values to "http" or "both". Now it returns the standard values ("grpc", "rest", "grpc+rest") directly, aligning Java with other languages. After merging, we will merge googleapis/google-cloud-java#13586, once we update the librarian pseudo-version and regenerate the repo-metadata values. Fixes #4854
|
|
|
Blocked by b/529301688, attempting to diagnose the other errors. |
sofisl
changed the title
|
I would not update anything inside sdk-platform-java/hermetic_build/library_generation. These are hermetic build scripts that I am working on deleting next (we are unblocked from deleting after #13569) |
|
Also, I've seen a few checks flaky lately. If the ci failures are unrelated and the check required, retry it. |
|
Close in favor of #13619 that updates to a newer version |
2 participants
This PR is an accompaniment to googleapis/librarian#6582. It regenerates all libraries to librarian to v0.23.1-0.20260630163952-027103b81777 and updates the accompanying scripts that modify the repo-metadata values.