Fix HMAC JWK import length handling#303
Open
harrshita123 wants to merge 3 commits into
Open
Conversation
jonasfj
reviewed
Jul 8, 2026
jonasfj
reviewed
Jul 8, 2026
harrshita123
force-pushed
the
codex/hmac-jwk-length
branch
from
8e351d9 to
554da8c
Compare
harrshita123
force-pushed
the
codex/hmac-jwk-length
branch
from
554da8c to
b22f865
Compare
Contributor
Author
|
Sorry, I accidentally clicked the close button. I have reopened the PR. |
Keep both the upstream js_interop import and the HMAC JWK base64Url import in the JS implementation.
harrshita123
force-pushed
the
codex/hmac-jwk-length
branch
from
c8c9ea2 to
c4479da
Compare
Contributor
Author
|
@jonasfj I resolved all conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #302.
What changed
lengthon HMAC JWK import as an expected key length, not as a request to alter key material.jwk.klength and reject non-zero unused trailing bits whenlengthis not byte-aligned.Testing
/Users/apple/flutter/bin/dart run lib/src/testing/regression/issue_302_hmac_jwk_length.dart/Users/apple/flutter/bin/dart test test/webcrypto_test.dart/Users/apple/flutter/bin/dart analyze(existing info-level lints only)