Feat/replace nlohmann with rapidjson #70
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces the nlohmann/json library with rapidjson throughout the project. Changes include: - Updated CMakeLists.txt to remove nlohmann/json and add rapidjson using FetchContent. - Resolved GTest target collisions by removing rapidjson's vendored GTest. - Added MNN as a dependency and configured its build flags to reduce compilation time. - Refactored all C++ source and header files (.hpp, .cpp) in 'include', 'examples', and 'tests' directories. - Replaced nlohmann/json includes and API calls with their rapidjson equivalents. - Updated minja::Value to wrap rapidjson::Value, including memory management considerations and a temporary bridge constructor from nlohmann::json to aid the transition. Current Status: I've completed the C++ code refactoring to use rapidjson. I've also addressed the CMake configuration for dependencies (rapidjson, MNN, GTest). However, the full project build (`make`) is consistently timing out. I suspect this is due to the compilation time of the MNN library, even with numerous features disabled. Further work is needed to resolve the MNN build timeout to verify the correctness of this refactoring through testing.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Hello, I see this PR has been open for several months without recent activity. Are there any plans to move it forward? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.