Skip to content

fix(core): buffer chat compression telemetry #28162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mturac wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(core): buffer chat compression telemetry #28162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 21 additions & 8 deletions packages/core/src/telemetry/loggers.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,16 +183,29 @@ describe('loggers', () => {
).toHaveBeenCalledWith(event);
});

it('records the chat compression event to OTEL', () => {
it('buffers the chat compression OTEL event and metrics', () => {
const bufferTelemetryEvent = vi
.spyOn(sdk, 'bufferTelemetryEvent')
.mockImplementation(() => {});
const mockConfig = makeFakeConfig();
const event = makeChatCompressionEvent({
tokens_before: 9001,
tokens_after: 9000,
});

logChatCompression(
mockConfig,
makeChatCompressionEvent({
tokens_before: 9001,
tokens_after: 9000,
}),
);
logChatCompression(mockConfig, event);

expect(bufferTelemetryEvent).toHaveBeenCalledTimes(1);
expect(mockLogger.emit).not.toHaveBeenCalled();
expect(metrics.recordChatCompressionMetrics).not.toHaveBeenCalled();

const bufferedCallback = bufferTelemetryEvent.mock.calls[0]![0];
bufferedCallback();

expect(mockLogger.emit).toHaveBeenCalledWith({
body: event.toLogBody(),
attributes: event.toOpenTelemetryAttributes(mockConfig),
});

expect(metrics.recordChatCompressionMetrics).toHaveBeenCalledWith(
mockConfig,
Expand Down
21 changes: 11 additions & 10 deletions packages/core/src/telemetry/loggers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,17 +460,18 @@ export function logChatCompression(
event: ChatCompressionEvent,
): void {
ClearcutLogger.getInstance(config)?.logChatCompressionEvent(event);
bufferTelemetryEvent(() => {
const logger = logs.getLogger(SERVICE_NAME);
const logRecord: LogRecord = {
body: event.toLogBody(),
attributes: event.toOpenTelemetryAttributes(config),
};
logger.emit(logRecord);

const logger = logs.getLogger(SERVICE_NAME);
const logRecord: LogRecord = {
body: event.toLogBody(),
attributes: event.toOpenTelemetryAttributes(config),
};
logger.emit(logRecord);

recordChatCompressionMetrics(config, {
tokens_before: event.tokens_before,
tokens_after: event.tokens_after,
recordChatCompressionMetrics(config, {
tokens_before: event.tokens_before,
tokens_after: event.tokens_after,
});
});
}

Expand Down