Skip to content

Conversation

@kleonc
Copy link
Member

@kleonc kleonc commented Dec 10, 2025

Makes TileSetScenesCollectionSource::get_scene_tile_display_placeholder ignore transform bits encoded within the passed alternative id, just like it's done in TileSetScenesCollectionSource::get_scene_tile_scene:

bool TileSetScenesCollectionSource::get_scene_tile_display_placeholder(int p_id) const {
ERR_FAIL_COND_V(!scenes.has(p_id), false);
return scenes[p_id].display_placeholder;
}

Ref<PackedScene> TileSetScenesCollectionSource::get_scene_tile_scene(int p_id) const {
int scene_tile = TileSetAtlasSource::alternative_no_transform(p_id);
ERR_FAIL_COND_V(!scenes.has(scene_tile), Ref<PackedScene>());
return scenes[scene_tile].scene;
}

It was making e.g. placing transformed scene tiles spam errors.

Before (v4.6.dev6.official [dec5a37]):

Godot_v4.6-dev6_win64_9EsGjZTyG1.mp4

After (this PR):

godot.windows.editor.dev.x86_64_3ejjzzaWsZ.mp4

@kleonc kleonc added this to the 4.6 milestone Dec 10, 2025
@kleonc kleonc requested a review from a team as a code owner December 10, 2025 17:44
@Repiteo Repiteo merged commit 4f4f272 into godotengine:master Dec 11, 2025
39 of 40 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Dec 11, 2025

Thanks!

@kleonc kleonc deleted the tile_set_fix_transformed_scene_get_placeholder_error branch December 12, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants