Skip to content

Reorganize editor menu setup, allow switching global menu without restart. #113800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akien-mga merged 1 commit into from
Dec 17, 2025
Merged

Reorganize editor menu setup, allow switching global menu without restart. #113800

akien-mga merged 1 commit into from
Dec 17, 2025
+363 −256

Conversation

@bruvzg
Copy link
Member

@bruvzg bruvzg commented Dec 9, 2025

  • Fixes a bunch of issues with main menu mode switching (wrong items in the menus, and mix of global and embedded menus).
  • Cleans up menu creation.
  • interface/editor/use_embedded_menu editor option now is fully applied without restart.

@bruvzg bruvzg added this to the 4.x milestone Dec 9, 2025
@bruvzg bruvzg marked this pull request as ready for review December 9, 2025 13:25
@bruvzg bruvzg requested a review from a team as a code owner December 9, 2025 13:25
KoBeWi
KoBeWi approved these changes Dec 13, 2025
View reviewed changes
Copy link
Member

@KoBeWi KoBeWi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems fine.

@akien-mga
Copy link
Member

akien-mga commented Dec 17, 2025

There's a couple review comments to address, then it should be good to merge.

@bruvzg
Copy link
Member Author

bruvzg commented Dec 17, 2025

There's a couple review comments to address, then it should be good to merge.

Done.

@akien-mga akien-mga modified the milestones: 4.x, 4.6 Dec 17, 2025
@akien-mga akien-mga merged commit 8e4847e into godotengine:master Dec 17, 2025
20 checks passed
@akien-mga
Copy link
Member

akien-mga commented Dec 17, 2025

Thanks!

@passivestar passivestar mentioned this pull request Dec 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KoBeWi KoBeWi KoBeWi approved these changes

Assignees

No one assigned

Labels

bug platform:macos topic:editor topic:gui

Projects

None yet

Milestone

4.6

Development

Successfully merging this pull request may close these issues.

3 participants

@bruvzg @akien-mga @KoBeWi