Skip to content

Conversation

@callpraths
Copy link

A proof-of-concept implementation for feature #2829

After this change, the tabs behind popups use grayed out foreground to better focus user's attention onto the popup.

This PR needs at least the following before it can be merged:

  • Agreement on the approach (discussion on the tracking issue).
  • Extend theme so users can configure the muted foreground color chosen for masking.
  • Other items in the checklist below.

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog

"args": [],
"cwd": "${workspaceRoot}",
}
},
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

split into own PR, if at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant