Improved metrics on composite glyphs, more legible numerals #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- zero with slash and one with serifs is the new default appearance, stylistic alts added (ss09, ss10) for original characters - Fixed metrics on composite glyphs - Improved sizing and spacing for the misc characters brought from standard Mona Sans - Small sample of coding ligatures
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request implements typography improvements for the MonaSansMono font, focusing on metrics corrections and enhanced readability through modified default numeral appearances and new stylistic alternates.
Key Changes:
- Updated default zero and one glyphs to slashed zero and serifed one for improved legibility
- Added stylistic sets (ss09, ss10) to access original zero/one designs
- Corrected glyph widths from 619 to 618 units across numerous characters for consistent monospace metrics
- Introduced sample coding ligatures (!=, ==, =>, ||, &&, ::)
- Refined positioning and spacing for composite glyphs and special characters
Reviewed changes
Copilot reviewed 265 out of 516 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| exclamdown.ss01.glyph | Width correction (619→618) and minor coordinate adjustment for inverted exclamation mark |
| exclam_equal.liga.glyph | New coding ligature for != operator |
| equal_greater.liga.glyph | New coding ligature for => arrow operator |
| equal_equal.liga.glyph | New coding ligature for == comparison operator |
| euro.glyph | Redesigned euro symbol with improved curve structure and width correction |
| emptyset.glyph | Simplified slash positioning for empty set symbol |
| ellipsis.ss01.glyph | Adjusted positioning and scaling for stylistic set variant |
| eight.tf.glyph | Converted to component reference from inline paths |
| degree.glyph | Repositioned to higher vertical placement with adjusted metrics |
| downArrow.glyph | Refactored to use upArrow component with 180° rotation |
| dottedCircle.glyph | Comprehensive coordinate adjustments for all dot positions |
| colon_colon.liga.glyph | New coding ligature for :: scope operator |
| bar_bar.liga.glyph | New coding ligature for |
| ampersand_ampersand.liga.glyph | New coding ligature for && logical operator |
| IJ.glyph | Converted from component references to inline paths |
| _notdef.glyph | Updated fallback glyph design |
| _zero.tf.base.glyph | Removed (likely replaced by slash variant as default) |
| SPC.glyph | Added space character definition |
| Multiple composite glyphs | Width corrections and positioning adjustments for accented characters |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ref = colon; | ||
| } | ||
| ); | ||
| width = 600; |
There was a problem hiding this comment.
Inconsistent width value. The m020 layer has width 600 while m019 layer has width 618. All monospace glyphs should maintain consistent width across layers.
Collaborator
Author
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
|
@kylewaynebenson I've opened a new pull request, #99, to work on those changes. Once the pull request is ready, I'll request review from you. |
…dth to 618 Co-authored-by: kylewaynebenson <[email protected]>
Fix width inconsistency in colon_colon ligature for monospace font
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR: