-
Notifications
You must be signed in to change notification settings - Fork 106
Mona Sans Display styles and Mona Sans Mono #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Creating clearer division between google fonts and other exports
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Not sure why google is generating this!!
Build is happening locally, these build/qa steps aren't needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request introduces major enhancements to the Mona Sans typeface family, including the addition of a monospace variant, weight adjustments for better visual matching, and display styles with an optical size axis for improved appearance across different sizes.
- Added Mona Sans Mono companion across all upright weights in regular width
- Adjusted weight matching to provide more expected appearance, especially for regular weight
- Introduced Display masters for all upright styles with optical size (opsz) axis support
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Updating the build process, and updated the css and family size documentation to reflect the larger space.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 2336 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Updated images to reflect latest design
images were too wide
tobiasahlin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking amazing @kylewaynebenson - my only gripe is renaming the VF into "VF" - I think this should be our default path (sans VF), but it's not a hill I'm going to die on
|
A lot of the reasoning in the Mona Mono brief are, kindly, "inaccurate". The bold range clearly goes higher than the screenshot:
Matching SF Mono is a fairly arbitrary goal. And missing entirely is the fact that Monaspace offers five typographic variants for the same metrics. Finally "not under our control" is a pretty strange thing to put in a brief when the people are right there in slack, and you didn't bother reaching out to talk with them. @kylewaynebenson @tobiasahlin I'm jazzed for new releases, but this was not a great way to communicate about them. |
|
Hi @idan! Im sorry if this came across as a critique. That PDF was not for the public. A mistake caused by a PR with a few too many changes bundled together. As you said, I'll send you a Slack and we can connect about the goals for Mona Sans. |

This pull request introduces work from the last several months:
Mona Sans Mono
This is a mono companion across all upright weights in the regular width.
Mona Sans Mono Development.pdf
Mona Sans Weight Matching
Mona's weight has been dialed in to match a more expected appearance. The most significant changes were made to the regular weight.
Mona Sans Weight Matching.pdf
Mons Sans Display (and
opszaxis)Last, and maybe biggest, is the addition of Display masters for all the upright styles of Mona Sans. The addition of an OPSZ axis means automatic better appearance across all sizes.
Mona Sans Display Development.pdf