feat(chat): add fast mode control#2873
Open
janburzinski wants to merge 3 commits into
Open
Conversation
Contributor
Greptile SummaryThis PR adds fast-mode control to ACP chat sessions. The main changes are:
Confidence Score: 5/5This looks safe to merge.
|
| Filename | Overview |
|---|---|
| packages/core/src/acp/reducer/config-derive.ts | Adds fast-mode derivation and preserves config groups omitted from partial updates. |
| packages/runtime/src/acp-agents/session/cell.ts | Maps fast-mode changes to the provider-owned config option ID. |
| apps/emdash-desktop/src/renderer/features/conversations/acp/acp-chat-store.ts | Exposes fast-mode state and updates to the renderer. |
| packages/ui/src/react/components/chat-composer/index.tsx | Adds the fast-mode selector to the model menu. |
Reviews (2): Last reviewed commit: "fix(acp): preserve config groups on part..." | Re-trigger Greptile
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Codex and Claude expose fast mode as provider-owned ACP config options, but Emdash previously ignored those categories, so users could not view or change the setting from chat.
Demo
https://cap.link/mam1dvkjp6yz93v