Do not add tests if project is included via add_subdirectory/FetchContent#8
Merged
traversaro merged 5 commits intomainfrom Apr 7, 2025
Merged
Do not add tests if project is included via add_subdirectory/FetchContent#8traversaro merged 5 commits intomainfrom
traversaro merged 5 commits intomainfrom
Conversation
dariosortino
approved these changes
Apr 7, 2025
dariosortino
left a comment
There was a problem hiding this comment.
Honestly way out of my knowledge but approving to ack the modification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had a failure in a project that included
serial_cppviaFetchContent, as it started to enableBUILD_TESTING, and we experience the failure:The additional dependency on GTest if one enable
BUILD_TESTINGdefinitely breaks POLA.A more user-friend behavior is to disable tests if
PROJECT_IS_TOP_LEVELis OFF, unless someone really needs them enabled, in that case the new advanced optionserial_cpp_FORCE_RESPECT_BUILD_TESTINGcan be used to force them to be enabled even ifPROJECT_IS_TOP_LEVELis OFF.