Skip to content

Conversation

@Rangi42
Copy link
Contributor

@Rangi42 Rangi42 commented Dec 1, 2025

Fixes #1863

Screen Shot 2025-12-04 at 09 51 01

@Rangi42 Rangi42 added this to the 1.0.1 milestone Dec 1, 2025
@Rangi42 Rangi42 requested a review from ISSOtm December 1, 2025 19:46
@Rangi42 Rangi42 added docs This affects the documentation (web-specific issues go to rgbds-www) rgbgfx This affects RGBGFX labels Dec 1, 2025
@Rangi42
Copy link
Contributor Author

Rangi42 commented Dec 1, 2025

@quinnyo Do you think the above rewrite is more clear?

Copy link
Contributor

@quinnyo quinnyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your efforts!

This is certainly an improvement, but it seems to be a better description of what I understood/expected the feature to be. It doesn't clarify the behaviour that caught me out.

The observed behaviour (#1863) indicates that the transformation is not applied when outputting palettes, but more universally to all colour inputs. The behaviour that surprised me is that this includes colours from a palette in the native format of the target platform.
Given a palette in the native format of the target platform, it would not be unreasonable to assume the palette is in the native colour space of the target platform.

Additionally, the phrase "when outputting palettes" may imply that the behaviour is conditional on whether or not a palette file is being written out.

@Rangi42 Rangi42 self-assigned this Dec 3, 2025
@Rangi42
Copy link
Contributor Author

Rangi42 commented Dec 3, 2025

Thank you @quinnyo! I see your point. How about:

-C, --color-curve
Modifies the color palettes (whether they are generated from the input image or taken from an input palette specification) with a color curve mimicking the Game Boy Color's screen. This adjusts the absolute RGB color values so that the perceived colors, when displayed on Game Boy Color hardware (or an emulator with an accurate display filter), will look like the original colors as displayed on a backlit computer screen. Note that GBC displays can look very different depending on the ambient light and their exact hardware model, so this color curve is only a "best effort".

@quinnyo
Copy link
Contributor

quinnyo commented Dec 4, 2025

Yep, looks good!

@Rangi42 Rangi42 removed the request for review from ISSOtm December 4, 2025 15:30
@Rangi42 Rangi42 merged commit a6eb645 into gbdev:master Dec 4, 2025
24 checks passed
@Rangi42 Rangi42 deleted the color-curve branch December 4, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs This affects the documentation (web-specific issues go to rgbds-www) rgbgfx This affects RGBGFX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RGBGFX badly describes the effect and purpose of --color-curve

2 participants