Skip to content

Fix out-of-bounds image slices #1713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ISSOtm merged 2 commits into from
Jul 2, 2025
Merged

Fix out-of-bounds image slices #1713

ISSOtm merged 2 commits into from
Jul 2, 2025

Conversation

@Rangi42
Copy link
Contributor

@Rangi42 Rangi42 commented Jul 1, 2025

Fixes #1712

@Rangi42 Rangi42 added this to the 0.9.4 milestone Jul 1, 2025
@Rangi42 Rangi42 requested a review from ISSOtm July 1, 2025 22:06
@Rangi42 Rangi42 added bug Unexpected behavior / crashes; to be fixed ASAP! rgbgfx This affects RGBGFX labels Jul 1, 2025
ISSOtm
ISSOtm approved these changes Jul 1, 2025
View reviewed changes
Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you ^^

ISSOtm
ISSOtm reviewed Jul 1, 2025
View reviewed changes
@Rangi42 Rangi42 marked this pull request as draft July 1, 2025 22:35
@Rangi42 Rangi42 requested a review from ISSOtm July 2, 2025 03:59
@Rangi42 Rangi42 marked this pull request as ready for review July 2, 2025 04:10
ISSOtm
ISSOtm approved these changes Jul 2, 2025
View reviewed changes
Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@ISSOtm ISSOtm merged commit 468f1cd into gbdev:master Jul 2, 2025
23 checks passed
@Rangi42 Rangi42 deleted the slice branch July 2, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ISSOtm ISSOtm ISSOtm approved these changes

Assignees

No one assigned

Labels

bug Unexpected behavior / crashes; to be fixed ASAP! rgbgfx This affects RGBGFX

Projects

None yet

Milestone

0.9.4

Development

Successfully merging this pull request may close these issues.

RGBGFX segfault

2 participants

@Rangi42 @ISSOtm