refactor(identity): split UserService into single-responsibility services #1192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ices (#1174) Split the UserService god class into focused, single-responsibility services: **New Interfaces (Modules.Identity.Contracts/Services/):** - IUserRegistrationService: User registration and external auth - IUserProfileService: Profile CRUD operations - IUserStatusService: Status toggle and delete operations - IUserRoleService: Role assignment operations - IUserPasswordService: Password operations (forgot/reset/change) - IUserPermissionService: Permission queries and caching **New Implementations (Modules.Identity/Services/):** - UserRegistrationService - UserProfileService - UserStatusService - UserRoleService - UserPasswordService - UserPermissionService **Other Changes:** - UserService now acts as a facade delegating to the new services - Updated DI registration in IdentityModule.cs - Deleted 7 old partial class files This improves: - Single Responsibility Principle compliance - Testability (smaller focused services) - Maintainability (clear separation of concerns) - Reusability (handlers can inject specific services they need) Closes #1174
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Splits the UserService god class into focused, single-responsibility services for better maintainability and testability.
Changes
New Interfaces (Modules.Identity.Contracts/Services/)
New Implementations (Modules.Identity/Services/)
Other Changes
Benefits
Build Status
Closes #1174