fix: retry missing attestation hashes#101
Merged
Merged
Conversation
DaniPopes
requested review from
0xrusowsky,
grandizzy,
mattsse and
onbjerg
as code owners
mablr
reviewed
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes foundryup treat an attestation payload that is missing hashes for the configured binaries as a retryable semantic failure, using the same FOUNDRYUP_MAX_RETRIES setting as HTTP retries. If the payload remains unusable, the error now reports which binary hashes were missing and which attestation subjects were present.
It also accepts path-shaped attestation subjects by matching the final path component, so attestations that include target paths can still verify the installed binary names.