-
Notifications
You must be signed in to change notification settings - Fork 4
fix: draft releases #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request modifies the release process to correctly upload the release asset and exclude the 'dependencies' label from the release drafter. Sequence diagram for the updated release asset upload processsequenceDiagram
participant GH as GitHub Actions
participant R as GitHub Release
GH->>GH: Create ZIP archive of firmware
Note over GH: Zip ESP01Firmware.ino.bin
GH->>R: Upload ZIP as release asset
Note over R: Using --clobber to overwrite if exists
Flow diagram for the modified release drafting processflowchart LR
A[PR Merged] --> B[Release Drafter]
B --> C{Check Labels}
C -->|dependencies label| D[Exclude from Release Notes]
C -->|Other labels| E[Include in Release Notes]
E --> F[Draft Release]
D --> F
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @AsCress - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
This PR is labelled 'Fix'. We should standardize whether labels are lower-case or upper-case. I suggest lower-case, since Github's default labels are lower-case. |
|
@bessman Right. Let's follow lowercase then. I'll update the labels and this PR. |
Summary by Sourcery
CI: