Derive additional credential scopes from the UC Delta credentials API#4
Open
foss-contributor wants to merge 1 commit into
Open
Derive additional credential scopes from the UC Delta credentials API#4foss-contributor wants to merge 1 commit into
foss-contributor wants to merge 1 commit into
Conversation
The API vends one credential per location; a table's data can span locations beyond its own, so capture the non-primary scopes instead of dropping them. Signed-off-by: foss-contributor <282724952+foss-contributor@users.noreply.github.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PRs · foss-contributor/unitycatalog (fork-internal)
A 2-PR stack, both based on
main. Review/merge bottom-up: #4 → #5.This PR is the base of the stack: 1 commit, and its Files changed is its own 6 files.
PR Checklist
docsis updatedDescription of changes
Part 1 of 2 (splits the previous combined change). This is the producer half; PR 2 consumes it. No behavior change on its own.
A table's data can span storage locations beyond the table's own, and the UC Delta credentials API vends one credential per location. The connector kept only the credential covering the table's own location and dropped the rest, so reads of data under the other locations would fail.
This change captures the others:
ScopedCredential— a vended credential bound to a location prefix.GenericCredentialFetcher.additionalScopedCredentials()— empty by default.UCDeltaGenericCredentialFetchersplits the Delta response into the primary plus the additional scopes.DeltaStorageCredentialUtil.toAdditionalScopedCredentialsconverts each non-primary cloud credential, skipping prefixes the connector can't translate (e.g.file://) and defaulting a missing operation toREAD.Tests:
DeltaStorageCredentialUtilTest,UCDeltaGenericCredentialFetcherTest.