feat: upgrade base image and allow advertise url to be set#17
Merged
jwnx merged 2 commits intoApr 23, 2026
Merged
Conversation
Buster reached EOL, so we upgrade the base image to bookworm. Also, allow ETCD_ADVERTISE_CLIENT_URLS to be set. Useful for private networking. Signed-off-by: Juliana Oliveira <juliana@fly.io>
Contributor
Why don't we upgrade right up to trixie? |
gargakshit
reviewed
Apr 23, 2026
| && tar xzvf /tmp/etcd-${ETCD_VERSION}-linux-amd64.tar.gz -C /usr/local/bin --strip-components=1 | ||
|
|
||
| FROM debian:buster-slim | ||
| FROM debian:bookworm-slim |
Contributor
There was a problem hiding this comment.
Suggested change
| FROM debian:bookworm-slim | |
| FROM debian:trixie-slim |
gargakshit
approved these changes
Apr 23, 2026
Signed-off-by: Juliana Oliveira <juliana@fly.io>
gargakshit
deleted the
jwnx/feat-update-dockerfile-and-overwrite-advertise-url
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buster reached EOL, so we upgrade the base image to bookworm. Also,
allow ETCD_ADVERTISE_CLIENT_URLS to be set. Useful for private
networking.
Signed-off-by: Juliana Oliveira juliana@fly.io