Skip to content

Conversation

@chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Dec 10, 2025

as title. This is required due to our policy

context: flutter/flutter#179033

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@gemini-code-assist
Copy link

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but could you also add all the new workflow scripts here? I forgot about it before, but was reminded by the flake in expensive tests on this PR; adding them to the ignore list will avoid that problem for future PRs (although not this one since tool changes trigger all tests too).

@chunhtai
Copy link
Contributor Author

Hi @stuartmorgan-g , do you think we should add the entire .github/workflows/* into the ignored this?

@stuartmorgan-g
Copy link
Collaborator

I was trying to be as conservative as possible (per the comment a few lines up from where I linked), but I think doing a path.startsWith('.github/workflows/') should be safe enough.

Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry for the delay, I didn't notice that you'd requested a re-review.

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 5, 2026
@auto-submit auto-submit bot merged commit 03957f4 into flutter:main Jan 5, 2026
80 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 6, 2026
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Jan 6, 2026
flutter/packages@12eb764...d3f860d

2026-01-05 [email protected] [ci] Adds repo
checks in main branch for batch release (flutter/packages#10485)
2026-01-05 [email protected] [ci] Pins github
action commit hash (flutter/packages#10599)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants