docs(openspec): propose customizable keymap UI#117
Open
criscool wants to merge 2 commits into
Open
Conversation
13 tasks
redreamality
approved these changes
Jul 3, 2026
redreamality
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed PR #117.
This is a documentation-only OpenSpec proposal for customizable keymap UI. The scope is appropriately narrow and matches the expected proposal structure:
proposal.mdexplains why customizable keybindings are needed.design.mdcovers registry / override-layer / persistence / conflict-detection considerations.specs/editor-core/spec.mddefines expected editor-core behavior.tasks.mdbreaks the implementation into reviewable phases.
Validation notes:
- CLA is passing.
- The PR only adds OpenSpec documentation and does not touch runtime code.
- I also reviewed the related implementation PR #118; this proposal is useful as a standalone design artifact even if implementation details need to be reviewed separately.
Conclusion: approved from OpenSpec/proposal review perspective.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 摘要
OpenSpec proposal for a user-overridable keybinding API on
EditorAPI, unblocking Roadmap #14 (Custom keymap UI). Proposal only — no implementation code.Motivation / 背景与动机
docs/ROADMAP.mddocs(openspec): propose realtime collaboration plugin #14 (Custom keymap UI, P2) — explicitly blocked on "expose keymap register / query API first"Nexus currently has three unrelated shortcut surfaces (
NexusPlugin.shortcuts,EditorCommand.hotkey, plugincmExtensionsdirect injection) with no discovery / override / persistence contract. FollowingCONTRIBUTING.md§3.1: new public capability → OpenSpec proposal required before implementation.Companion implementation PR will be opened right after this one (branch
feat/core-editor-apis), so reviewers can see the proposal and its execution together.Changes / 变更内容
openspec/changes/add-customizable-keymap-ui/:proposal.md— Why / What / Impacttasks.md— 5-phase implementation checklistdesign.md— Context / Goals / 4 key decisions with alternatives / Risks / Migration / Open Questionsspecs/editor-core/spec.md—ADDED Requirements: User-overridable keybindingswith 9 scenarios covering discovery, rebinding, unbinding, restore, conflicts, unknown-id tolerance, initial hydrationTesting / 测试
N/A — proposal-only PR. Implementation coverage lives in the companion PR.
Compliance / 合规自检
Checklist / 自检清单
docs(openspec): ...)Precedent for proposal-only PR: #15
docs(openspec): propose cloud storage interface.