Skip to content

Conversation

@lucasmrod
Copy link
Member

@lucasmrod lucasmrod commented Dec 26, 2025

Resolves #37686.

Rolling back the detail query change in 527c223.
The test in the original commit was not related to the change so I kept it as it was added to make sure order of processing of query results.

I tested the ingested device ID matches the one in Entra and that Yes/No compliant functionality works as expected.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.

Testing

  • QA'd all new/changed functionality manually

@codecov
Copy link

codecov bot commented Dec 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.88%. Comparing base (d254667) to head (2dd8ddf).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #37687      +/-   ##
==========================================
- Coverage   65.88%   65.88%   -0.01%     
==========================================
  Files        2361     2361              
  Lines      187298   187298              
  Branches     8010     8010              
==========================================
- Hits       123395   123394       -1     
+ Misses      52621    52619       -2     
- Partials    11282    11285       +3     
Flag Coverage Δ
backend 67.73% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rollback Entra conditional access code that fetches legacy Entra Device IDs from the keychain

3 participants