refactor: rename env var to FB_AWS_EC2_METADATA_CLIENT_ENABLED#10
Merged
Conversation
The flag gates initialization of the aws-sdk EC2 metadata client, which queries the IMDS endpoint (169.254.169.254) for instance identity and IRSA-style credentials. The previous name (FIREBOLT_ALLOW_AWS_IRSA) described one use case rather than what the flag actually controls; the new name reflects the underlying behavior. Semantics are unchanged: the metadata client stays disabled unless the variable is set to a truthy value.
fstr
requested changes
May 26, 2026
fstr
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
rename env var to FB_AWS_EC2_METADATA_CLIENT_ENABLED.
Issue
Note
Medium Risk
Renaming the env var is a breaking operational change for deployments still using
FIREBOLT_ALLOW_AWS_IRSA; misconfiguration would leave EC2 IMDS/credential paths disabled.Overview
Renames the opt-in environment variable that controls whether
InitEC2MetadataClientruns fromFIREBOLT_ALLOW_AWS_IRSAtoFB_AWS_EC2_METADATA_CLIENT_ENABLED. Behavior is unchanged: the EC2 metadata client stays off unless that variable is truthy.Comments in
InitEC2MetadataClientare updated to describe disabling IMDS (169.254.169.254) by default and enabling via the new name, instead of framing it as IRSA.Deploy note: any runtime that still sets
FIREBOLT_ALLOW_AWS_IRSAmust switch toFB_AWS_EC2_METADATA_CLIENT_ENABLEDor IMDS-based credentials/metadata will not initialize.Reviewed by Cursor Bugbot for commit ce357c0. Bugbot is set up for automated code reviews on this repo. Configure here.