This repository is currently being migrated. It's locked while the migration is in progress.
Shared pool #12
Open
Shared pool #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruplelesswizard
left a comment
scruplelesswizard
left a comment
There was a problem hiding this comment.
Not that I can validate the code, but the concept sounds solid! Thanks @ckoehn!
dermorz
approved these changes
Apr 27, 2018
Contributor
dermorz
left a comment
dermorz
left a comment
There was a problem hiding this comment.
Let's try this with a locally running festung used in the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr introduces a shared connection pool, on the driver level, for all festung queries. Previously we were using one session per user/request (update: I think this sentence is wrong. We create one
sessionper thread.) . This seems to be unnecessary overhead, because we are always connecting to the same festung host and can re-use the tcp connections to speed things up.This pr also introduces a one-time retry behavior, because we are having quite some
ConnectionErrorentries in sentry.One additional optimization is to make the interface of the
Connectionbackwards compatible by adding asessionkwarg or accepting just**kwargs.Any kind of input is highly appreciated 😉