Skip to content

Conversation

@Mazuh
Copy link
Contributor

@Mazuh Mazuh commented Jun 23, 2022

Checklist

Mazuh added 5 commits June 14, 2022 05:46
removing directories with .sync is limited on windows
so I refactored my test to always use an available folder
instead of concurring with the existing one
@mcollina mcollina marked this pull request as ready for review June 24, 2022 18:22
@mcollina
Copy link
Member

There are conflicts now.

@Mazuh Mazuh marked this pull request as draft June 27, 2022 14:44
@Mazuh
Copy link
Contributor Author

Mazuh commented Jun 27, 2022

sadly, tests will pass but users will still see an error (it's the blocking issue that I attached in the description), it's a third-party blocker... so I'll mark as draft just to be safe that nobody will merge even if I fix the conflicts.

I'll see if I can do something about the error before going back to this.

@mcollina
Copy link
Member

mcollina commented Jul 4, 2022

What's the status of this?

@Mazuh
Copy link
Contributor Author

Mazuh commented Jul 5, 2022

@mcollina I'm engaging in the discussion (standard/ts-standard#222), but right now I'm already open to workarounds (like using another linter simple as the standard for TS).

@theoludwig
Copy link

theoludwig commented Jul 15, 2022

@mcollina I'm engaging in the discussion (standard/ts-standard#222), but right now I'm already open to workarounds (like using another linter simple as the standard for TS).

@Mazuh As a contributor/maintainer of ts-standard, I recommend switching to ESLint (using https://github.com/standard/eslint-config-standard-with-typescript).
There is no energy and willpower for updating ESLint to v8 in ts-standard currently, no one on the team. 😅
But if anyone wants to help ts-standard to move things forward, and be simpler than ESLint (like standard for JavaScript), they can take a look at this: standard/ts-standard#222 (comment)
Basically, a rewrite of ts-standard, we accept PRs and will be happy to review them.

EDIT: I found some free time to rewrite ts-standard, follow the progress and the future of ts-standard here: standard/ts-standard#254

@voxpelli
Copy link

Would be happy to work closer with the Fastify community on Standard related matters.

As a co-maintainer of Standard, a user of Fastify myself and a freelancer with lot of power over my own time I could try to help out where there is a need.

@climba03003
Copy link
Member

As a contributor/maintainer of ts-standard, I recommend switching to ESLint

I am agreed on using the combination of ESLint and eslint-config-standard-with-typescript. Although both ts-standard and eslint-config-standard-with-typescript is barely maintain. But eslint-config-standard-with-typescript recently upgraded and released for ESLint@8.

I don't know how long will it take for ts-standard and a accept the workaround for using ESLint with plugin.

Basically, a rewrite of ts-standard, we accept PRs and will be happy to review them.

I will see if I can give a hand on it. Is there any working progress started?
Really love to see the dependencies narrow to a single one when it happen.

@Mazuh
Copy link
Contributor Author

Mazuh commented Jul 26, 2022

I'll try to take a look on what needs to be done here this weekend (I was super busy with something else in the last days, sorry).

@simoneb
Copy link
Contributor

simoneb commented Sep 13, 2022

I think we can close this PR, I don't think it will receive any more activity

@Mazuh Mazuh closed this Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants