fix[devtools]: feature-check structure stack trace methods #35293
+47
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoxyq
force-pushed
the
devtools/feature-check-structured-stack-trace-methods
branch
from
a93e9d9 to
465c2be
Compare
hoxyq
force-pushed
the
devtools/feature-check-structured-stack-trace-methods
branch
from
465c2be to
c2bacca
Compare
hoxyq
added a commit
that referenced
this pull request
Dec 5, 2025
Follow-up to #34641. Similar to #35293, #35294. React DevTools backend can be used in non-DOM environments, so we have to feature-check some DOM APIs. For now I am just no-oping newly added commands for Native, we should revisit this decision once we would roll out Suspense panel there, if needed. I am not sure if scrolling will be required as much as it is needed on Web. `isReactNativeEnvironment()` check is kinda clowny, but we've been relying on it for quite some time already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error.prepareStackTraceis non-standard feature and not all JavaScript runtimes implement the methods that we are using in React DevTools backend.This PR adds additional checks for the presence of the methods that we are using.