[compiler] Fix computed property keys in object method shorthand #35248
+95
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes facebook#35203 The compiler was incorrectly discarding computed property key notation when used with method shorthand syntax, transforming `[key]() {}` into `key() {}`. Changed the hardcoded `false` parameter to `property.key.kind === 'computed'` in CodegenReactiveFunction.ts to preserve computed keys, matching the pattern already used for regular object properties.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #35203
The compiler was incorrectly discarding computed property key notation
when used with method shorthand syntax, transforming
[key]() {}intokey() {}.Changed the hardcoded
falseparameter toproperty.key.kind === 'computed'in CodegenReactiveFunction.ts to preserve computed keys, matching the
pattern already used for regular object properties.
How did you test this change?
TDD, adding tests